matchai / spacefish

🚀🐟 The fish shell prompt for astronauts
https://spacefish.matchai.dev
MIT License
963 stars 79 forks source link

Improve package version detection using jq, python and node #107

Closed matchai closed 5 years ago

matchai commented 5 years ago

The following improvement made to the package section in spaceship should be ported over to spacefish to improve the accuracy of the version shown.

🐟 spacefish-bot — Pull request copied from: https://github.com/denysdovhan/spaceship-prompt/pull/441.

grep solution to fetch version package.json was hacky and wasn't always returning expected values. Now using other fallback methods to get version information, Following discussions from denysdovhan/spaceship-prompt#439

Changes

Fix denysdovhan/spaceship-prompt#439 Close denysdovhan/spaceship-prompt#552 Close denysdovhan/spaceship-prompt#553

tiffafoo commented 5 years ago

This was done in #143 🎉