Fix "bad math expression" pmset bug

matchai commented 5 years ago

Description

Ported over the same solution as was made in spaceship.

Motivation and Context

Closes #106

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

I was unfortunately unable to test this fix, though it seems trivial enough not to lead to any issues. We really need to write tests for the battery section.

[ ] I have tested using MacOS
[ ] I have tested using Linux

Checklist:

[x] I have checked that no other PR duplicates mine
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have updated the tests accordingly.

Snuggle commented 5 years ago

Lookin' good to me.

I wonder why was this grep added in the first place? Tests for the battery section would be amazing, I just don't have a spare moment to add some at the moment. It seems upstream need tests for battery too, but I still need to install npm on my laptop to run their tests, which unfortunately, npm has >200 dependencies on Ubuntu.

matchai commented 5 years ago

If I'm not mistaken, you should be able to run the spaceship tests without npm by running ./scripts/tests.sh. 🤔

Thanks for the review! 👍

salmanulfarzy commented 5 years ago

That's correct @matchai.

@Snuggle There is no need to install npm to run tests of spaceship. npm test is just a convenience wrapper around ./scripts/tests.sh.

You can also run individual tests with ./tests/<name>.test.zsh or zsh tests/<name>.test.zsh

matchai / spacefish