Kubernetes included with Docker 18.09 sets the kubectl-section to always be enabled

MindTooth commented 5 years ago

Bug Report

Current Behavior With the recently released Docker 18.09 (Version 2.0.0.0-mac78), I experience that the Kubernetes section is always enabled. The reason for that is Kubernetes is now included with Docker, and the kubectl command is therefore always present. The current check is only wether if the command is present or not.

Expected Behavior The prompt added with https://github.com/matchai/spacefish/pull/76 should only be visible when needed. Inside a config folder (Dockerfile, etc. Don't know how Kube works.)

Environment

Spacefish version: [the output of echo $SPACEFISH_VERSION] 1.9
Fish version: [the output of fish --version] fish, version 2.7.1-1181-g18a163dc
Fish plugin manager: [e.g. oh-my-fish, fisher, fin] fundle
Terminal emulator: [e.g. iTerm, Hyper, Terminator] kitty
Operating system: [e.g. OSX 10.13.4, Windows 10] macOS Mojave

Possible Solution

Only load the section when needed.

Additional context/Screenshots

Add any other context about the problem here. If applicable, add screenshots to help explain.

matchai commented 5 years ago

It looks to me like this same issue would occur on spaceship with the latest version of Docker. I think it would be best if we let them address it first.

++ @salmanulfarzy in case they want to open an issue

matchai commented 5 years ago

Upon further investigation, it looks like this same issue doesn't occur on Spaceship ZSH 3.8.1 (latest right now). I'll see if I can find the cause of the problem. 🕵️

matchai commented 5 years ago

Looks I missed a bit of logic when reading over the spaceship implementation. 😅 Should be quickly fixed with the upcoming PR.

Sorry for the wait!

matchai / spacefish

Kubernetes included with Docker 18.09 sets the kubectl-section to always be enabled #111

Bug Report