matchai / spacefish

🚀🐟 The fish shell prompt for astronauts
https://spacefish.matchai.dev
MIT License
963 stars 79 forks source link

Dropping pyenv in favor of python section #112

Open matchai opened 5 years ago

matchai commented 5 years ago

Looks like we've got a bit of updating to do for the pyenv section. This would also be a great opportunity to add testing where we don't have any at the moment. 😄

🐟 spacefish-bot — Pull request copied from: https://github.com/denysdovhan/spaceship-prompt/pull/431.

Description

Dropping pyenv section in favor of python section, python section has three display modes.

Variable Value Meaning
SPACESHIP_PYTHON_SHOW always Always display python version information if relevant files exist in directory
SPACESHIP_PYTHON_SHOW true (default) Display python version only inside virtual environment if relevant files exist
SPACESHIP_PYTHON_SHOW false Don't display python version in prompt

Screenshot

python version inside virtualenv

Tasks

Related denysdovhan/spaceship-prompt#394 Close denysdovhan/spaceship-prompt#410

salmanulfarzy commented 5 years ago

Note it was merged to 4.0 branch and not to master.

matchai commented 5 years ago

Good call. I'll have this planned for 2.0, which will be parallel to spaceship's 4.0 👍

CSergienko commented 5 years ago

Hello! Does this mean that the theme will support other python version managers, like ASDF, virtualenvwrapper, etc, in the near future?

Thank you for the awesome work you've done porting this theme to fish.

matchai commented 5 years ago

As soon as such features are added to spaceship, we aim to add support for equivalent features in spacefish. 😄

CSergienko commented 5 years ago

Fair enough.