search

matchai / spacefish

🚀🐟 The fish shell prompt for astronauts
https://spacefish.matchai.dev
MIT License
963 stars 79 forks source link

cannot install github.com/matchai/spacefish -- is this a valid package? #116

Closed gertcuykens closed 5 years ago

gertcuykens commented 5 years ago 
> fisher add matchai/spacefish
fetching https://codeload.github.com/matchai/spacefish/tar.gz/master
cannot install github.com/matchai/spacefish -- is this a valid package?
done in 2.32s

config.fish

if not functions -q fisher
    set -q XDG_CONFIG_HOME; or set XDG_CONFIG_HOME ~/.config
    curl https://git.io/fisher --create-dirs -sLo $XDG_CONFIG_HOME/fish/functions/fisher.fish
    fish -c fisher
end

Environment

matchai commented 5 years ago

Hmm... That is strange indeed. 🤔

I just tested installation on the latest version of fisher and had no problems. Please make sure you're running the latest version of fisher with fisher self-update.

Alternatively, maybe try cloning it locally and installing it providing the local path: fisher add ~/path/to/spacefish.

gertcuykens commented 5 years ago 
gertc@DESKTOP MSYS ~ $ fish                                                                           
gertc@DESKTOP ~> fisher self-update
fetching https://raw.githubusercontent.com/jorgebucaran/fisher/master/fisher.fis h 
fisher is already up-to-date
gertc@DESKTOP ~> fisher add matchai/spacefish
fetching https://codeload.github.com/matchai/spacefish/tar.gz/master
cannot install github.com/matchai/spacefish -- is this a valid package?
done in 2.41s
gertc@DESKTOP ~> git clone https://github.com/matchai/spacefish.git
Cloning into 'spacefish'...                                                      
remote: Enumerating objects: 59, done.                                           
remote: Counting objects: 100% (59/59), done.                                    
remote: Compressing objects: 100% (41/41), done.                                 
remote: Total 1017 (delta 32), reused 33 (delta 18), pack-reused 958             
Receiving objects: 100% (1017/1017), 5.27 MiB \| 6.14 MiB/s, done.                
Resolving deltas: 100% (647/647), done.                                          
gertc@DESKTOP ~> fisher add ~/spacefish                                  
fetching https://codeload.github.com/matchai/spacefish/tar.gz/master             
fetching https://codeload.github.com/spacefish/tar.gz/master                     
cannot install github.com/spacefish -- is this a valid package?                  
cannot install github.com/matchai/spacefish -- is this a valid package?          
linking ~/.config/fish/functions/__sf_lib_section.fish                           
linking ~/.config/fish/functions/__sf_section_aws.fish                           
linking ~/.config/fish/functions/__sf_section_battery.fish                       
linking ~/.config/fish/functions/__sf_section_char.fish                          
linking ~/.config/fish/functions/__sf_section_conda.fish 
...
~/.config/fish/functions/fish_right_prompt.fish                          
added 1 package in 6.55s                                                                                                                                          gertc in ~ took 6s 778ms

So I assume windows and fisher is not going to work out?

matchai commented 5 years ago

It looks to me like you may have several spacefish entries in your fisher configuration, but it ends up working. The last few lines are what you would see when installing spacefish correctly:

linking ~/.config/fish/functions/__sf_lib_section.fish                           
linking ~/.config/fish/functions/__sf_section_aws.fish                           
linking ~/.config/fish/functions/__sf_section_battery.fish                       
linking ~/.config/fish/functions/__sf_section_char.fish                          
linking ~/.config/fish/functions/__sf_section_conda.fish 
...
~/.config/fish/functions/fish_right_prompt.fish

I would suggest removing any extraneous spacefish installs in fisher ls, or just starting clean with fisher ls | fisher rm.

gertcuykens commented 5 years ago

Correct after cleaning C:\msys64\home\gertc\.config\fish\fishfile making sure only ~/spacefish is included fisher self-update doesn't try to fetch the first two attempts anymore.

So basicly the git clone manually like you suggest is a valid workaround, thanks. But the original fisher problem still remains, it's just not a show stopper anymore :) I believe it going to be a fisher specific bug not related to spacefish. Can you confirm this then I will open a ticket at the fisher repo

matchai commented 5 years ago

I haven't had any luck reproducing this issue on my macOS, so it might be a Windows or MSYS2-specific issue. I encourage you to open a ticket on the fisher repo. 👍

Snuggle commented 5 years ago

I've had some weirdness occur with Fisher and Spacefish on either a Windows or BSD system before, I presumed it might've been an isolated event but maybe not. Best luck with the bug report! 💕