matchai / spacefish

🚀🐟 The fish shell prompt for astronauts
https://spacefish.matchai.dev
MIT License
963 stars 79 forks source link

Fira Code font symbols missing in vscode windows 10 #118

Closed gertcuykens closed 5 years ago

gertcuykens commented 5 years ago
{
    "terminal.integrated.shell.windows": "C:\\msys64\\usr\\bin\\fish.exe",
    "terminal.integrated.env.windows": {
        "MSYSTEM": "MSYS"
    },
    "terminal.integrated.fontSize": 16,
    "terminal.integrated.fontFamily":"Fira Code",
    "editor.fontSize": 16,
    "editor.fontLigatures": true, 
    "editor.fontFamily":"Fira Code",
    "git.path": "C:\\git\\bin\\git.exe",
}

image

Also tried Fira Mono for Powerline but I can't seem to figure out how to display the last character in my case golang symbol

Second, In PowerShell terminal the arrow doesn't seem rendered correctly

image

salmanulfarzy commented 5 years ago

Fira Code was used for git branch symbol, Which is correctly rendered on VS Code. Go lang section use emoji and that's the one displayed as boxes. Windows have terrible support for Unicode symbols.

I don't use Windows, So until any fellow Windows users are able to help, You could customize it with SPACEFISH_GOLANG_SYMBOL.

gertcuykens commented 5 years ago

Ok thx, what about the arrow in PowerShell is it also a emoji?

matchai commented 5 years ago

The arrow isn't an emoji, though it is in the UTF-8 character set. It looks like you have to enable UTF-8 explicitly in Powershell with chcp 65001 (details here).

gertcuykens commented 5 years ago

Can't believe windows still doesn't use UTF-8 by default... Now I can see UTF-8 chracters that I type but arrow still seem to go trough something else. image

gertcuykens commented 5 years ago

Lets abandon the PowerShell for now because I have a feeling that thing is just legacy beyond imagination. If we would manage to get the vscode terminal working would be great, the reason I think it's still doable is that the editor itself has no emoji problem so it might be a terminal js problem but still think this can be fixed

image

Snuggle commented 5 years ago

Heya! :rainbow::sparkles:

This doesn't exactly seem like an Spacefish-specific issue and I don't believe anyone here will be able to help other than upstream. (Best of luck with the issue you've replied to above!)

As @salmanulfarzy said earlier, if you have another symbol that works in the meantime that you'd like to use, you can add set SPACEFISH_GOLANG_SYMBOL 🌮 to your ~/.config/fish/config.fish to override the default arrow icon with a taco.

If you have any further topic-related questions, feel free to ask, but this issue should be closed and I'll add the appropriate tags. :two_hearts: