Remove all cut and sort references (Let's cut it out!) - Githubissues

matchai / spacefish

🚀🐟 The fish shell prompt for astronauts

https://spacefish.matchai.dev

MIT License

963 stars 79 forks source link

Remove all cut and sort references (Let's cut it out!) #119

Closed matchai closed 5 years ago

matchai commented 5 years ago

Description

Trim away the use of unnecessary GNU utilities for better compatibility across the board.

Remove existing references to cut
Remove unnecessary use of sort in git status (Solves #117)

Motivation and Context

Closes #117

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

[x] I have tested using MacOS
[ ] I have tested using Linux

I have tested version.fish to ensure it still works after these changes 👍

Checklist:

[x] I have checked that no other PR duplicates mine
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have updated the tests accordingly.

Snuggle commented 5 years ago

Hm, I wish there were some automated tests here! Just testing locally now.

[Edit] Huh, there was absolutely no need for sort? Sweet!

matchai commented 5 years ago

Cheers! 🥂 Thanks @gertcuykens for spotting this bug. Much appreciated! 😄