Add option to display current commit id in git info prompt

ohcibi commented 5 years ago

Description

With the same semantic as for SPACEFISH_GITBRANCH* setup a commit id is displayed right next to the branch name. From my own experience of setting up a prompt git is likely to require its own "order" mechanism as PROMPT and RPROMPT already have in spacefish. This is not a matter of this PR but something to concern if this gets accepted as I might add other stuff regarding git as well. I have the status info string (i.e. the symbols for "staged", "delete", "modified", etc.) in my RPROMPT for example and I plan to modify spacefish's git module to support that.

Motivation and Context

Showing additional information about the git repository is good! 👍

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

https://www.dropbox.com/s/g1d98o9crlkvaei/Screenshot%202019-01-11%2012.43.52.png?dl=0

How Has This Been Tested?

[x] I have tested using MacOS
[ ] I have tested using Linux

Checklist:

[x] I have checked that no other PR duplicates mine
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] ~I have updated the tests accordingly.~

matchai commented 5 years ago

Hey @ohcibi. Thank you for opening a PR to add extended git info! 🍻

It appears this feature would be the spacefish equivalent to the following spaceship PR: https://github.com/denysdovhan/spaceship-prompt/pull/443 🚀

Since that PR is on hold while the team decides which sections should remain enabled by default (https://github.com/denysdovhan/spaceship-prompt/issues/492), we will be putting this PR on hold as well to maintain feature parity.

Hopefully discussions won't take too long. 😄

ohcibi commented 5 years ago

Apparently the other pr does exactly the same as mine so this one might as well be closed. One question/concern though:

As I said what’s more importantly needed than any default setting is the ability to change the order of each git subsection and to be able to put the subsection apart from each other. Is there any work/discussions going on regarding this? I’m thinking of just using the current ordering logic recursively with named subsets. Eg (pseudo code)

git = create_subset git_commit git_branch
prompt_order = foo bar git 
rprompt_order = git_info

matchai commented 5 years ago

Apparently the other pr does exactly the same as mine so this one might as well be closed.

That PR is on the spaceship ZSH project, which spacefish is a port of. Your PR is still needed as it will be used to port over the new feature when it is introduced to the other codebase. 😄

As I said what’s more importantly needed than any default setting is the ability to change the order of each git subsection and to be able to put the subsection apart from each other. Is there any work/discussions going on regarding this?

Yes, there are conversations regarding git section modularity, which will also likely be introduced in the next major version of spaceship ZSH: https://github.com/denysdovhan/spaceship-prompt/issues/375 https://github.com/denysdovhan/spaceship-prompt/pull/391

There's a lot of work lined up for the coming months as spaceship ZSH prepares for the major 4.0.0 release (https://github.com/denysdovhan/spaceship-prompt/issues/491)

matchai commented 5 years ago

Closing this issue until a similar feature is implemented upstream.

matchai / spacefish