style: run fish_indent on all *.fish files

matchai commented 5 years ago

Description

Having ran fish_indent on all the fish files in the project, our fish files should be more consistently indented and formatted in the fish style.

You may notice that early returns are now on a new line. I personally don't mind this change, but I can see it bothering others. In the end, I'm happy with anything as long as it's consistent. If we agree to the styling of fish_indent, it may be worthwhile to add it as a git hook on *.fish files with Husky. Thoughts?

Another quick note is that test files have not been formatted. It is a known issue that fish-tape files are not fish_indent compatible, so I reindented them to fit with the 4-space indentation of fish_indent.

Click here for the non-whitespace changes! ✨

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

[ ] I have tested using MacOS
[ ] I have tested using Linux

Checklist:

[x] I have checked that no other PR duplicates mine
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have updated the tests accordingly.

tiffafoo commented 5 years ago

@matchai , I have the same thought for wanting consistency, but I am still kind of bothered with the newlines, especially here :p

matchai commented 5 years ago

Hm... I totally agree. 🤔 Hopefully, a Fish AST will be made available sooner than later. I'd love to create a Prettier plugin for processing Fish files.

I'll leave this open for now to allow for more discussion. I can be persuaded to go either way at this point.

matchai / spacefish