feat: add `SPACEFISH_PROMPT_BOLD` option

kiurchv commented 5 years ago

Description

This change adds an ability to toggle font weight of prompt via SPACEFISH_PROMPT_BOLD option

Motivation and Context

It will be great to have the ability to disable default bold styling of the prompt

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

[x] I have tested using MacOS
[ ] I have tested using Linux

Checklist:

[x] I have checked that no other PR duplicates mine
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have updated the tests accordingly.

matchai commented 5 years ago

Thank you @kiurchv for the contribution! 😄 I'd love to get this merged in as soon as the feature is approved in https://github.com/denysdovhan/spaceship-prompt/pull/519.

For the time being, would you be able to add tests for the new configuration option to __sf_lib_section.test.fish and __sf_section_dir.test.fish?

kiurchv commented 5 years ago

Hey, @matchai! I've added some tests and rebased my commits on the current master

matchai commented 5 years ago

Thank you @kiurchv! It appears there's still some uncertainty about how they plan to implement this feature upstream in spaceship, so I'm still a little hesitant to merge this in. 🤔

I'll keep an eye on the conversation and will keep you updated.

matchai commented 5 years ago

Closing this PR until the associated feature is implemented upstream.

matchai / spacefish