We shouldn't use porcelain git commands

matchai / spacefish

🚀🐟 The fish shell prompt for astronauts

https://spacefish.matchai.dev

MIT License

960 stars 78 forks source link

We shouldn't use porcelain git commands #163

Closed Snuggle closed 5 years ago

Snuggle commented 5 years ago

Bug Report

Current Behavior We shouldn't be parsing porcelain commands as they don't have a stable output. This is apparently heavily discouraged.

https://stackoverflow.com/questions/6976473/what-does-the-term-porcelain-mean-in-git

Possible Solution Switch to "plumbing" commands, whatever those be.

Additional context/Screenshots https://github.com/matchai/spacefish/blob/d6de532b97423da3e6bd538084065f1ed96c03a7/functions/__sf_section_git_status.fish#L36

Snuggle commented 5 years ago

I can fix this within the next couple of hours and also check that Spaceship is squeaky clean too. 😊

Snuggle commented 5 years ago

Ah, it appears the flag does the opposite of what one would think, instead of showing the porcelain/pretty version, --porcelain actually shows the plumming version.

The current is :+1:, my mistake, will close this issue.