matchai / spacefish

šŸš€šŸŸ The fish shell prompt for astronauts
https://spacefish.matchai.dev
MIT License
960 stars 78 forks source link

Fix typo in venv generic names variables #167

Closed k-lyda closed 5 years ago

k-lyda commented 5 years ago

Description

I think this there is a leftover from migrating venv section from Spaceship prompt - name of the variable containing venv generic names is SPACESHIP_VENV_GENERIC_NAMES instead of SPACEFISH_VENV_GENERIC_NAMES

Motivation and Context

In the documentation name for this var is SPACEFISH_VENV_GENERIC_NAMES. If you add a line to config.fish according to the documentation, the generic names array is not updated, cause spaceship does not take var SPACEFISH_VENV_GENERIC_NAMES into account, it only looks for SPACESHIP_VENV_GENERIC_NAMES

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

matchai commented 5 years ago

@all-contributors please add @k-lyda for bug

allcontributors[bot] commented 5 years ago

@matchai

I've put up a pull request to add @k-lyda! :tada:

matchai commented 5 years ago

:tada: This PR is included in version 2.3.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: