matchai / spacefish

🚀🐟 The fish shell prompt for astronauts
https://spacefish.matchai.dev
MIT License
963 stars 77 forks source link

SPACEFISH_HOST_SHOW valid values #196

Closed halbrd closed 5 years ago

halbrd commented 5 years ago

Bug Report

Current Behavior According to the docs at https://spacefish.matchai.me/docs/Options.html#char, the valid values for SPACEFISH_HOST_SHOW should be true and false.

(no SSH session was active)

SPACEFISH_HOST_SHOW = true does not cause the host to be displayed SPACEFISH_HOST_SHOW = always causes the host to be displayed

Expected Behavior The docs imply that

SPACEFISH_HOST_SHOW = true should cause the host to be displayed SPACEFISH_HOST_SHOW = always should be invalid

Relevant Fish Configuration

set SPACEFISH_PROMPT_ORDER user host dir

set SPACEFISH_HOST_SHOW         always
set SPACEFISH_HOST_PREFIX       'on '
set SPACEFISH_HOST_COLOR        red
set SPACEFISH_HOST_COLOR_SSH    green

Environment

Possible Solution I think the docs just need to be updated.

Additional context/Screenshots N/A

matchai commented 5 years ago

:tada: This issue has been resolved in version 2.6.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: