matchai / spacefish

🚀🐟 The fish shell prompt for astronauts
https://spacefish.matchai.dev
MIT License
964 stars 79 forks source link

Implement prompt section for ruby version #35

Closed matchai closed 6 years ago

matchai commented 6 years ago

Feature Description

This feature is implemented once we have reached feature parity with the following spaceship section: https://github.com/denysdovhan/spaceship-prompt/blob/master/sections/ruby.zsh

Expected Behaviour

avegancafe commented 6 years ago

Are there any other ruby version managers that we should create for this feature to be complete? Assuming asdf is a placeholder 😄

tiffafoo commented 6 years ago

@kyleholzinger The ruby version managers left are chruby and asdf (the unchecked boxes above).

asdf is indeed real 😆: https://github.com/asdf-vm/asdf

Spacefish implementation reference: https://github.com/denysdovhan/spaceship-prompt/blob/master/sections/ruby.zsh#L37

avegancafe commented 6 years ago

Hahahah oh man, alright well I'm not familiar with that one but I'll give a shot at chruby!

avegancafe commented 6 years ago

Were we still thinking of doing asdf? @matchai #46 only did chruby, not sure if that's in the works

tiffafoo commented 6 years ago

Yeah asdf still open @kyleholzinger. It just closed because when you have an issue preempted by closes/fix, etc. it closes the issue automatically. Reopened!