Add ruby version implementation - Githubissues

matchai / spacefish

🚀🐟 The fish shell prompt for astronauts

https://spacefish.matchai.dev

MIT License

964 stars 79 forks source link

Add ruby version implementation #39

Closed tiffafoo closed 6 years ago

tiffafoo commented 6 years ago

Description

Shows Ruby version in directories that contain Gemfile, or Rakefile, or any other file with .rb extension.

Variable	Default	Meaning
`SPACEFISH_RUBY_SHOW`	`true`	Show Ruby section
`SPACEFISH_RUBY_PREFIX`	`$SPACEFISH_PROMPT_DEFAULT_PREFIX`	Prefix before Ruby section
`SPACEFISH_RUBY_SUFFIX`	`$SPACEFISH_PROMPT_DEFAULT_SUFFIX`	Suffix after Ruby section
`SPACEFISH_RUBY_SYMBOL`	`💎·`	Character to be shown before Ruby version
`SPACEFISH_RUBY_COLOR`	`red`	Color of Ruby section

Motivation and Context

For #35 (missing two)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

screen shot 2018-03-17 at 4 38 38 pm

How Has This Been Tested?

[X] I have tested using MacOS
[X] I have tested using Linux

Tests with other ruby managers other than rvm is needed

Checklist:

[X] I have checked that no other PR duplicates mine
[x] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

To do:

Add chruby and asdf, like spaceship has. We did have an implementation of this, but due to being too lazy to test, removed it so this PR could be merged