Closed matchai closed 6 years ago
This looks beautiful, but perhaps it would be better to somehow merge the current banner into the title? Maybe remove the background and move things around a little. (Awesome banner, by the way! I think it should still be kept somewhere prominent on the page.)
Have a look at Electron's GitHub page for inspiration? https://github.com/electron/electron
@Snuggle Thank you for the kind words regarding the banner! π I, too, was thinking that the banner needed a little reworking.
I playing around with it and seeing if there's any way we could better integrate it. I think replacing the existing one for the top left version would be better. Thoughts?
Yeah, I agree the top left one looks the nicest by far, with the top right one in second place - not quite a fan of the split bottom two.
Is there an SVG available of the top-left or...? It looks awesome!
Oh whoops! I was meaning to say the top right! π Because it has thinner dimensions, the title would look less removed from the banner.
I'm making them all in Figma as vectors, so they're available as svgs: https://www.figma.com/file/OHv3PPmBNfFuBhVYt7w7qS8h/Banner
Thoughts on using this?
Yeah! I like it! :slightly_smiling_face:
I think I prefer the emojis on the right, though. It looks a bit weird otherwise.
This is intended to improve accessibility of documentation and better UI. But, this comes at cost of including HTML directly inside markdown due to limitations of markdown syntax and affects readability of README.
Description
Motivation and Context
Mirrors https://github.com/denysdovhan/spaceship-prompt/pull/505
Types of changes
Screenshots (if appropriate):
Before
After
How Has This Been Tested?
Checklist: