Add kubernetes namespace to kubecontext section when present

owais commented 5 years ago

Shows active kubectl namespace in addition to context rendered as $symbol $context.$namespace

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

[ ] I have tested using MacOS
[x] I have tested using Linux

Checklist:

[x] I have checked that no other PR duplicates mine
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have updated the tests accordingly.

matchai commented 5 years ago

Hey owais!

Thank you for taking the time to open a PR. Unfortunately, this feature would break parity with spaceship-prompt, which this project is a port of.

I do think that would be value to having the kubectl namespace added to the prompt and would encourage you to first make an issue or PR over on the spaceship project. Once the issue is approved on spaceship-prompt and it looks like it is planned to be merged in, we can pick up this PR again.

Sorry about that. Hopefully we can get your PR merged in the near future. 😅

owais commented 5 years ago

Ok. No worries.I'll use my fork till then :)

matchai / spacefish