Add section to show the active PHP version - Githubissues

matchai / spacefish

🚀🐟 The fish shell prompt for astronauts

https://spacefish.matchai.dev

MIT License

963 stars 79 forks source link

Add section to show the active PHP version #80

Closed matchai closed 5 years ago

matchai commented 5 years ago

Description

Implement Rust version section based on the implementation on spaceship.

Show version section when composer.json or *.php are present
Write tests for the new section
Update documentation with the new section

Motivation and Context

Closes #67

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

[x] I have tested using MacOS
[ ] I have tested using Linux

Checklist:

[x] I have checked that no other PR duplicates mine
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have updated the tests accordingly.

matchai commented 5 years ago

I have a PR lined up after this one fixing some consistency in sections that you mentioned above. 👍