Clean up the codebase and improve consistency - Githubissues

matchai / spacefish

🚀🐟 The fish shell prompt for astronauts

https://spacefish.matchai.dev

MIT License

963 stars 79 forks source link

Clean up the codebase and improve consistency #81

Closed matchai closed 5 years ago

matchai commented 5 years ago

Description

A bit of tidying up around the codebase.

Reorder the checks done within sections
Format checks more consistently within sections
Add missing file checks that exist within spaceship
Add missing tests for sections and file checks

Motivation and Context

Tidying up the codebase.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

[x] I have tested using MacOS
[ ] I have tested using Linux

Checklist:

[x] I have checked that no other PR duplicates mine
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have updated the tests accordingly.