Dotnet section - Githubissues

matchai / spacefish

🚀🐟 The fish shell prompt for astronauts

https://spacefish.matchai.dev

MIT License

963 stars 79 forks source link

Dotnet section #83

Closed ladysamantha closed 5 years ago

ladysamantha commented 5 years ago

Add a .NET SDK section to the prompt.

Description

Add a .NET SDK section based on the dotnet-cli.

Motivation and Context

Adds a new section to have greater parity with the ZSH version.

Closes #71

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

screen shot 2018-10-12 at 19 18 59

How Has This Been Tested?

[x] I have tested using MacOS
[ ] I have tested using Linux

Checklist:

[x] I have checked that no other PR duplicates mine
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have updated the tests accordingly.

ladysamantha commented 5 years ago

More tests need to be added for this section, but I wanted to open the PR anyway just to get it started!

ladysamantha commented 5 years ago

Errrm I also just noticed that this PR added my other commits for some reason. If you need me to close this and make a new one, just let me know!

matchai commented 5 years ago

Looks good so far! 👍 If you put "WIP", "Work In Progress" or "Do Not Merge" in the title of the PR, our WIP GitHub App will stop me from accidentally merging it. Just a heads up. 😄

No need to worry about the commit history. I'll be squash-merging it. 🥞

matchai commented 5 years ago

Hey @ladysamantha! 👋 It's been a little over a month. Just want to check up with you and see if you're still working on this.

ladysamantha commented 5 years ago

Hello 👋 I'm sorry for the delay, I was working on it and then got sidetracked by work and the holiday and haven't had a lot of time recently to work on it.

I have time this week to add the tests. I've blocked out time on my calendar to finish it.

matchai commented 5 years ago

It happens to everyone. No worries. 😄 Looking forward to reviewing your PR once you're done with it. 👍

matchai commented 5 years ago

Heya @ladysamantha! Just checking in to see if you're still interested in finishing this PR up. 😄 If you're too busy, I wouldn't mind finishing it up.

Whatever works for you 👍

ladysamantha commented 5 years ago

Sorry again for the delay; should be good to continue working on this PR during the holiday break. Just pushed the tests. Let me know what I need to fix 😄

matchai commented 5 years ago

Glad to hear it! 😄 It looks like you need to address a merge conflict in fish_prompt.fish before CI will run.