search

matchai / spacefish

🚀🐟 The fish shell prompt for astronauts
https://spacefish.matchai.dev
MIT License
963 stars 79 forks source link

Implement a prompt section for Docker version (🐳) #84

Closed matchai closed 5 years ago

matchai commented 5 years ago

Feature Request

Is your feature request related to a problem? Please describe. This feature is intended to achieve feature parity with the following Spaceship section file: https://github.com/denysdovhan/spaceship-prompt/blob/master/sections/docker.zsh

Describe the solution you'd like Porting over the existing zsh implementation of the Docker section file, showing the current Docker version and machine name when the prompt is in the same directory as a Dockerfile, docker-compose.yml or a compose file.

jskrnbindra commented 5 years ago

@matchai I would like to do this one. Will open a PR soon..!

matchai commented 5 years ago

Perfect! Looking forward to seeing your PR @jskrnbindra. 😄

jskrnbindra commented 5 years ago

Hey @matchai I have a question. Once I make any changes (say: add docker section), How do I test it (not talking about the tests/)? I mean how do I get the theme (with my changes) loaded into my terminal?

matchai commented 5 years ago

You should be able to install it with your fish package manager by providing a relative path to your local project. 

fisher add ./
jskrnbindra commented 5 years ago

@matchai I'm getting the following error. Am I missing something obvious? 🤔

fetching https://codeload.github.com/./tar.gz/master
rm: "." and ".." may not be removed
cannot install github.com/. -- is this a valid package?
added 1 package in 1.38s
matchai commented 5 years ago

I believe it might be because you ran fisher add . rather than fisher add ./ 😜 That should probably be an issue opened in Fisher. I ran into the same issue the other day.

jskrnbindra commented 5 years ago

I tried both. Same result. :/

matchai commented 5 years ago

Huh... How about providing the full path to the project directory? fisher add ./ works fine for me locally, but fisher ls shows the full path to the project. https://asciinema.org/a/UwKKqqZJ3QYPrkPdNEdIP8EN3

Make sure fisher is running the latest version with fisher self-update. A new major version of fisher was just released last week, so there's bound to be some quirky behavior.

jskrnbindra commented 5 years ago

Oh yes! Giving the full path instead of ./ works for me. Thanks. 😊