Closed jskrnbindra closed 5 years ago
Thank you for taking the time to contribute to spacefish, @jskrnbindra! 😄 Your PR is looking good! Just a few comments here and there.
🎉
Looks good to me! After those last couple comments, we should be good to go! 🚀
🎉 ?
It was my first PR. Thanks for being very patient and helping me throughout @matchai. 🎉 🎈 🎉
Not a problem! 😄 That was a great first PR. I'm glad you were able to contribute to our project! Hope to see you around. 👋
Missed to add docker
in Options.md under default order. 🙆🏻♂️
Implement Docker section based on the implementation on spaceship.
Motivation and Context
Closes #84
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: