Add section to show Conda version

matchai / spacefish

🚀🐟 The fish shell prompt for astronauts

https://spacefish.matchai.dev

MIT License

963 stars 79 forks source link

Add section to show Conda version #91

Closed jskrnbindra closed 5 years ago

jskrnbindra commented 5 years ago

Implement Conda section based on the implementation in spaceship.

Show conda version when CONDA_DEFAULT_ENV and conda is installed
Write tests for new section
Update documentation with the new section

Motivation and Context

Closes #70

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

[x] I have tested using MacOS
[ ] I have tested using Linux

Checklist:

[x] I have checked that no other PR duplicates mine
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have updated the tests accordingly.

jskrnbindra commented 5 years ago

@Snuggle I don't know why my editor (VS Code) is doing this. 🤯 My VS Code is configured to insert 4 spaces when tab is pressed. What editor do you guys use?

Snuggle commented 5 years ago

I usually use micro for editing shell files, but I have made similar mistakes in the past. I think it's mostly something you'll have to pay attention to.

Micro is similar to nano, but has a lot more awesome features like copy/paste, ctrl + c/v shortcuts, automatic syntax highlighting and smart sudo.

Snuggle commented 5 years ago

This part is all over the place! The first two lines are at completely different indentation levels to the rest of this test.

jskrnbindra commented 5 years ago

@Snuggle I think this should do. Had to do in a trial-error way. I'll setup micro.

jskrnbindra commented 5 years ago

@Snuggle 🎉

Snuggle commented 5 years ago

Woo! Things now look pretty and I'm happy now! ✨

Now to see if @matchai has any more comments or feedback before being merged. 😊

matchai commented 5 years ago

@jskrnbindra I also use VSCode. Be sure to install the EditorConfig extension, which will read the .editorconfig file in the project root and use the correct indentation. 😄

jskrnbindra commented 5 years ago

@Snuggle @matchai Got a bit occupied, I'm travelling. Will do it in a couple of days.

jskrnbindra commented 5 years ago

@matchai good to go now?