matchboxdesigngroup / kindling

A WordPress theme that supports the Full Site Editing features.
MIT License
3 stars 0 forks source link

Remove theme attribute from wp:template-part tags #17

Closed unscripted closed 1 year ago

unscripted commented 1 year ago

Changes proposed in this pull request

This PR fixes an issue where the homepage returned the Template part has been deleted or is unavailable error when enabling another theme.

This issue was caused by the theme attribute being included in the wp:template-part tags for the header and footer of the home template.

A similar issue was detailed in https://github.com/WordPress/create-block-theme/issues/242, which is where I identified the fix.

Closes (GitHub issue number or Asana task link)

Pre-submit checklist

As the author of this pull request, I verify that:

Testing

How to test the changes in this pull request

Follow the steps below to test the changes in this PR.

  1. Deploy this branch to the dev environment.
  2. Navigate to the homepage to confirm there are no errors.
  3. Navigate to the Appearance > Themes page.
  4. Enable the kindling-child theme.
  5. Navigate to the homepage.

Functional tests

As the functional tester for this pull request, I verify that:

Once testing is complete, notify the author of any failed tests and move the task to "Kick back" in Asana. If all tests pass, move the task to "Ready for Code Review" in Asana and tag a team member for code review.

Code review

As the code reviewer for this pull request, I verify that:

Once testing is complete, notify the author of any failed tests and move the task to "Kick back" in Asana or continue with the "merging" steps below.

Merging

As the individual merging this pull request, I verify that:

┆Issue is synchronized with this Asana task