Open sync-by-unito[bot] opened 8 months ago
➤ Steve Struemph commented:
Cullen This repo was refactored and ddev was removed when the theme install process was changed to work with the utility that grabbed it via composer. I recommend we add it back.
Also when we do that, ddev needs to have node updated to 18.
Additionally, the theme needs maintenance. In the theme we should run yarn packages-upgrade to update the lock file.
Today I went to run a deploy test of Kindling on Parsons and I had just installed it locally 24 hours ago and it worked. I went back to that test and ran yarn in the ddev container. I need to update it from node 16 to 18 and then update the wpscripts package. Then I could run yarn and yarn build.
➤ Steve Struemph commented:
Cullen Also, I am happy to do these tasks but I wanted to get your thoughts on DDEV (in terms of us not using that utility script to load kindling via composer) and then let you know about the issue in case you run into issues when running yarn on a kindling project.
➤ Cullen commented:
I think it would be a good idea to split this into a couple of tasks. My reason for this is that the node packages should be updated without question, but I would like to discuss DDEV.
The DDEV discussion should not hold up the package updates.
Are you OK with us creating a separate task for the DDEV portion?
➤ Steve Struemph commented:
Having the DDEV files in the repo doesn't actually do anything unless you choose to use DDEV. It's just a yaml config file. Unless you handle DDEV outside of this repo. But that seems like overkill.
Here's the Parsons PR for reference. These files might actually work for updating. https://github.com/matchboxdesigngroup/parsons-blewitt/pull/1 ( https://github.com/matchboxdesigngroup/parsons-blewitt/pull/1 )
➤ Steve Struemph commented:
Cullen Re-read my comment and yours and realized I completely missed what you were asking for. I'll make a separate task for DDEV, remove those updates, and re-check the package updates on this branch.
This task is to update the Kindling repo.
Kindling sites updated:
┆Issue is synchronized with this Asana task