search

matchish / laravel-scout-elasticsearch

Search among multiple models with ElasticSearch and Laravel Scout
MIT License
705 stars 113 forks source link

Add support for php 8 #188

Closed fkeloks closed 2 years ago

fkeloks commented 2 years ago

In this PR, nothing more than an update of the package to make it compatible with php 8.
The version of Laravel does not change

Changes :

matchish commented 2 years ago

Hello. Have you tried this branch?https://github.com/matchish/laravel-scout-elasticsearch/tree/php8

matchish commented 2 years ago

Version 5 support php8

fkeloks commented 2 years ago

Hello,

I saw this branch too late. By the way, in the Releases tab of Github, the "latest" version is v4.0.9 and not this v5.

I still proposed this MR because it doesn't imply any update of other packages, no switch to laravel/scout v9 for example.

However I'm not sure about the usefulness of my PR, feel free to remove it if you want.

Have a nice day! 😃

matchish commented 2 years ago

I agree that it make sense to consider to merge it but for now your PR don't pass scrutinizer. So should be fixed first