search

matchish / laravel-scout-elasticsearch

Search among multiple models with ElasticSearch and Laravel Scout
MIT License
711 stars 115 forks source link

#202 lazyMap method implemented #205

Closed hkulekci closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #205 (431ed3d) into master (de9cedc) will increase coverage by 0.49%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #205      +/-   ##
============================================
+ Coverage     95.19%   95.68%   +0.49%     
- Complexity      176      178       +2     
============================================
  Files            34       34              
  Lines           499      510      +11     
============================================
+ Hits            475      488      +13     
+ Misses           24       22       -2
Impacted Files Coverage Δ
src/Engines/ElasticSearchEngine.php 93.54% <100.00%> (+5.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de9cedc...431ed3d. Read the comment docs.

hkulekci commented 2 years ago

I will improve the coverage.

matchish commented 2 years ago

I think make sense to keep MixedModel with Mixedsearch together

matchish commented 2 years ago

I mean in one file

hkulekci commented 2 years ago

instanceof solution worked far faster than reflection class solution. For this reason I choose this one.

hkulekci commented 2 years ago

All checks had passed 💯