search

matchish / laravel-scout-elasticsearch

Search among multiple models with ElasticSearch and Laravel Scout
MIT License
702 stars 113 forks source link

laravel version 10 support #237

Closed hkulekci closed 1 year ago

hkulekci commented 1 year ago

235

hkulekci commented 1 year ago

So :) we have some errors on the tests and some support issues for PHP 8.0.16. Let's discuss the further steps @matchish @adrianpaiva1

codecov-commenter commented 1 year ago

Codecov Report

Base: 96.05% // Head: 96.05% // No change to project coverage :thumbsup:

Coverage data is based on head (cf74377) compared to base (0d306e4). Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #237 +/- ## ========================================= Coverage 96.05% 96.05% Complexity 190 190 ========================================= Files 36 36 Lines 634 634 ========================================= Hits 609 609 Misses 25 25 ``` | [Impacted Files](https://codecov.io/gh/matchish/laravel-scout-elasticsearch/pull/237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Shlyakhov) | Coverage Δ | | |---|---|---| | [src/Engines/ElasticSearchEngine.php](https://codecov.io/gh/matchish/laravel-scout-elasticsearch/pull/237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Shlyakhov#diff-c3JjL0VuZ2luZXMvRWxhc3RpY1NlYXJjaEVuZ2luZS5waHA=) | `94.44% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Shlyakhov). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Shlyakhov)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

hkulekci commented 1 year ago

@matchish @adrianpaiva1 I think we are ready. Could you review the PR?