search

matchish / laravel-scout-elasticsearch

Search among multiple models with ElasticSearch and Laravel Scout
MIT License
702 stars 113 forks source link

stage interface improvement for stages #261

Closed hkulekci closed 11 months ago

hkulekci commented 11 months ago

I initialize a StageInterface to implement in stages. This is not like an improvement on logic but would be great for code structure. And if somebody want to add some extra custom stages, they can implement with using this interface.

codecov-commenter commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (97e5578) 96.06% compared to head (ce1cf4e) 96.08%. Report is 6 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #261 +/- ## ============================================ + Coverage 96.06% 96.08% +0.01% - Complexity 192 193 +1 ============================================ Files 36 36 Lines 636 638 +2 ============================================ + Hits 611 613 +2 Misses 25 25 ``` | [Files](https://app.codecov.io/gh/matchish/laravel-scout-elasticsearch/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Shlyakhov) | Coverage Δ | | |---|---|---| | [src/Jobs/Import.php](https://app.codecov.io/gh/matchish/laravel-scout-elasticsearch/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Shlyakhov#diff-c3JjL0pvYnMvSW1wb3J0LnBocA==) | `100.00% <ø> (ø)` | | | [src/Jobs/Stages/CleanUp.php](https://app.codecov.io/gh/matchish/laravel-scout-elasticsearch/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Shlyakhov#diff-c3JjL0pvYnMvU3RhZ2VzL0NsZWFuVXAucGhw) | `100.00% <ø> (ø)` | | | [src/Jobs/Stages/CreateWriteIndex.php](https://app.codecov.io/gh/matchish/laravel-scout-elasticsearch/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Shlyakhov#diff-c3JjL0pvYnMvU3RhZ2VzL0NyZWF0ZVdyaXRlSW5kZXgucGhw) | `100.00% <ø> (ø)` | | | [src/Jobs/Stages/PullFromSource.php](https://app.codecov.io/gh/matchish/laravel-scout-elasticsearch/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Shlyakhov#diff-c3JjL0pvYnMvU3RhZ2VzL1B1bGxGcm9tU291cmNlLnBocA==) | `100.00% <100.00%> (ø)` | | | [src/Jobs/Stages/RefreshIndex.php](https://app.codecov.io/gh/matchish/laravel-scout-elasticsearch/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Shlyakhov#diff-c3JjL0pvYnMvU3RhZ2VzL1JlZnJlc2hJbmRleC5waHA=) | `100.00% <ø> (ø)` | | | [src/Jobs/Stages/SwitchToNewAndRemoveOldIndex.php](https://app.codecov.io/gh/matchish/laravel-scout-elasticsearch/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Shlyakhov#diff-c3JjL0pvYnMvU3RhZ2VzL1N3aXRjaFRvTmV3QW5kUmVtb3ZlT2xkSW5kZXgucGhw) | `100.00% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/matchish/laravel-scout-elasticsearch/pull/261/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Sergey+Shlyakhov)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hkulekci commented 11 months ago

I could not understand what is the problem exactly with continuous-integration/styleci/pr.

hkulekci commented 11 months ago

Ahh I see. New lines 😭 Thanks for merging.