search

matchish / laravel-scout-elasticsearch

Search among multiple models with ElasticSearch and Laravel Scout
MIT License
702 stars 113 forks source link

feat: add php 8.3 compatibility #266

Closed jackraymund closed 9 months ago

jackraymund commented 9 months ago

As in ticket https://github.com/matchish/laravel-scout-elasticsearch/issues/265

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ddc0d97) 96.08% compared to head (1b4b596) 96.08%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #266 +/- ## ========================================= Coverage 96.08% 96.08% Complexity 193 193 ========================================= Files 36 36 Lines 638 638 ========================================= Hits 613 613 Misses 25 25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

matchish commented 9 months ago

Could you add 8.3 to matrix as well? https://github.com/matchish/laravel-scout-elasticsearch/blob/master/.github/workflows/test-application.yaml

jackraymund commented 9 months ago

Could you add 8.3 to matrix as well? https://github.com/matchish/laravel-scout-elasticsearch/blob/master/.github/workflows/test-application.yaml

Just added.