PHP-Parser not in direct dependencies, PHP-Parser > 5.0 is incompatible - Githubissues

matchish / laravel-scout-elasticsearch

Search among multiple models with ElasticSearch and Laravel Scout

MIT License

702 stars 113 forks source link

PHP-Parser not in direct dependencies, PHP-Parser > 5.0 is incompatible #273

Open danbka33 opened 6 months ago

danbka33 commented 6 months ago

Describe the bug

A new release of PHP-Parser has recently been released. https://github.com/nikic/PHP-Parser/releases/tag/v5.0.0

In the changelog you can see that the "create" method that was used has been removed. This method is used in this file: https://github.com/matchish/laravel-scout-elasticsearch/blob/9b675df4be7b0dd4a9599860bd5cb6def1a75664/src/Searchable/SearchableListFactory.php#L119

This package is not listed in direct dependencies, so it is allowed to install version 5, which is not compatible.

Options

Add version 4 to direct dependencies.
Go to version 5, add this to direct dependencies and fix the creation method.

matchish commented 4 months ago

v7.6.1 should fix the issue. could you provide a feedback?