matchish / laravel-scout-elasticsearch

Search among multiple models with ElasticSearch and Laravel Scout
MIT License
713 stars 115 forks source link

Indices aren't configured correctly when you dont use the `scout:import` command #46

Closed jdbolts closed 5 years ago

jdbolts commented 5 years ago

If you do not use the scout:import command, indexes are no longer appended with the time(). Which results in the following error:

{
   "error":{
      "root_cause":[
         {
            "type":"index_not_found_exception",
            "reason":"no such index",
            "resource.type":"index_or_alias",
            "resource.id":"index_name",
            "index_uuid":"_na_",
            "index":"index_name"
         }
      ],
      "type":"index_not_found_exception",
      "reason":"no such index",
      "resource.type":"index_or_alias",
      "resource.id":"index_name",
      "index_uuid":"_na_",
      "index":"index_name"
   },
   "status":404
}
matchish commented 5 years ago

How do you create the index?

jdbolts commented 5 years ago

They are created automatically when importing the data. If you do not use scout:import and save a new model the index is then also automatically created but without the timestamp at the end of the index name

matchish commented 5 years ago

Timestamp doesn't matter. Alias of an index is an identifier for search. Could create a minimally test to reproduce the issue?

jdbolts commented 5 years ago

If you create a simple Laravel application and install this package. Then create a simple model (let's say users) with a seeder. When you run the seeder an index will be created (users_index). However, if you don't run the seeder and instead run the artisan command scout:import before running the seeder, you will get an index created which will be users_index_TIMESTAMP. This causes issues when you have an empty application and do not run the scout import initially.

matchish commented 5 years ago

The index users_index_TIMESTAMP has an alias users_index so the index name can be anything user_index_uuid for example. The index index_user doesn't have an alias but it has a name that matches to right alias, so it's strange to get the error. I'll test the case later but now I can recommend using User::disableSearchSyncing() before seeding and User::enableSearchSyncing() after. Then you can run scout:import

jdbolts commented 5 years ago

I got around this issue by calling the scout:import on my migration before any data is imported. This way, the indices are created correctly and then when the seeder is called, or a model is created, the index already exists so is added correctly using the alias.

vrusua commented 1 year ago

@matchish

Hi Sergey,

sorry for pushing the legacy record, but I'm still getting the same issue on V6.0.2:

The missing index is creating correctly (with the alias and named timestamp) using the scout:import only when resending all the data. However, when we're calling some Eloquent updates, or running searchable() explicitly - the newly created index appears without the alias and named timestamp.

Is there any way to sort out this?

This option will be useful when we don't need to sync full the data to Elastic but just part only. Thanks.

Cheers, Ruslan

vrusua commented 1 year ago

@matchish or maybe some guide how to implement createIndex() for the scout:index option?

matchish commented 1 year ago

@vrusua Hey) Actually you're right. The package missing scout:index and scout:delete-index commands. I believe they have to be added here as well. The issue with scout-index it accept index name not a model and we need settings and mappings for new index and scout:index don't have those parameters. If you want to index only part of your data you can create a model that will represent that part by adding a global scope to it. Then just import that model. Updates of that model will go to the index as well.

matchish commented 1 year ago

@vrusua Feel free to implement createIndex method if you think that custom model can't solve your issue https://github.com/matchish/laravel-scout-elasticsearch/issues/223

vrusua commented 1 year ago

@vrusua ... If you want to index only part of your data you can create a model that will represent that part by adding a global scope to it. Then just import that model. Updates of that model will go to the index as well.

Yeah, got it, thanks for the workaround and a quick reply.