search

matchms / matchms-backup

Python library for fuzzy comparison of mass spectrum data and other Python objects
Apache License 2.0
0 stars 1 forks source link

consistent numpy usage #186

Closed jspaaks closed 4 years ago

jspaaks commented 4 years ago
  1. import numpy
  2. import numpy as np
  3. from numpy import asarray, hstack, sum etc

We chose to go with option 1

jspaaks commented 4 years ago

PR #191

sverhoeven commented 4 years ago

Why not option 2, this what numpy themselves use in their docs?

jspaaks commented 4 years ago

I guess it's an arbitrary choice. np is not much shorter than numpy, but it is slightly less clear.

cwmeijer commented 4 years ago

I would vote for option 2 because that's what many people use, but if this was decided earlier to go for option 1 then I don't want to resurrect this discussion ;-)