search

matchms / matchms-backup

Python library for fuzzy comparison of mass spectrum data and other Python objects
Apache License 2.0
0 stars 1 forks source link

Reduce number of peaks #209

Closed florian-huber closed 4 years ago

florian-huber commented 4 years ago

Address #208

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

florian-huber commented 4 years ago

Thanks @cwmeijer for the review! I added changes based on your comments, so just have a look if this indeed resolves it.

florian-huber commented 4 years ago

@HannoSpreeuw , since Chris has already done a review here, would it be OK to assign you for another PR instead. I imagine that #237 or #239 should also be closer to the profiling you work on.

cwmeijer commented 4 years ago

I unassigned @HannoSpreeuw as I think we sort of agreed at least one of us would have a look at this. You can merge this :-)

jspaaks commented 4 years ago

PR moved https://github.com/matchms/matchms/pull/33