matchms / matchms

Python library for processing (tandem) mass spectrometry data and for computing spectral similarities.
Apache License 2.0
189 stars 63 forks source link

Design useful processor default pipelines #528

Closed florian-huber closed 4 months ago

florian-huber commented 1 year ago

The SpectrumProcessor now has a few defaults such as minimal, basic, default...

But I believe it would be better to make them rather towards specific use cases that (we think) people might have. This can later of course always adapted based on user feedback!

Here a few suggestions:

basic and default could hence be removed. We could still set the default in the class to, say, lcms_non_annotated.

What do you think @niekdejonge @hechth ?

niekdejonge commented 1 year ago

Yes I agree. The minimal, basic, default are a bit arbitrary names. I have already made quite some changes in filter order, but have mainly focused on finalizing the fully annotated and ms2deepscore pipelines. I think we can just combine Minimal, Basic and Default into one pipeline called lcms_non_annotated, by removing the 4 inchikey related filters.

Now in pipeline the default settings are default, both for the reference and the query spectra, we can probably change this to query: lcms_non_annotated and reference: lcms_fully_annotated.

Additional pipelines, we can add once we discover new specific use cases, or leave this up to the user, since it is quite easy to create your own specific filter pipeline.

github-actions[bot] commented 5 months ago

This issue is stale because it has been open for 180 days with no activity.

github-actions[bot] commented 4 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.