search

matchms / ms2deepscore

Deep learning similarity measure for comparing MS/MS spectra with respect to their chemical similarity
Apache License 2.0
48 stars 22 forks source link

Implement GeneratorSettings and implement in rest of code #157

Closed niekdejonge closed 7 months ago

niekdejonge commented 8 months ago

Implements a GeneratorSettings class. This makes it easier to refactor later if we want to change a settings name.

During implementation I noticed we did not check before that the settings given are actually used, this resulted in us passing values to generators that were long outdated without getting a warning.

sonarcloud[bot] commented 8 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

97.1% 97.1% Coverage
6.7% 6.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint