matchms / ms2deepscore

Deep learning similarity measure for comparing MS/MS spectra with respect to their chemical similarity
Apache License 2.0
48 stars 22 forks source link

Integrate DataGeneratorCherryPicked with DataGeneratorBase #159

Closed niekdejonge closed 6 months ago

niekdejonge commented 8 months ago

DataGeneratorCherrypicked uses DataGeneratorBase but does not initialize the DataGeneratorBase, while it is the super class.

We use multiple methods from DataGeneratorBase, but the super init can not be run, since DataGeneratorBase uses reference_scores_df while DataGeneratorCherrypicked uses SelectedCompoundPairs.

Two options:

florian-huber commented 6 months ago

Outdated with #168