search

matchms / ms2deepscore

Deep learning similarity measure for comparing MS/MS spectra with respect to their chemical similarity
Apache License 2.0
48 stars 22 forks source link

Save version #176

Closed niekdejonge closed 5 months ago

niekdejonge commented 5 months ago

Save the version in the model and print a warning if the model is loaded that does not match the current version. We can later add more specific warnings (e.g. only add warnings if we know backwards compatibility is broken between versions). But in this way at least all pytorch models will have a version stored, making it backwards compatible if we implement this in more detail later. Solves #89

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

18 New issues
0 Security Hotspots
89.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

niekdejonge commented 5 months ago

Ah yes I created a test model in dev_pytorch, which was not made with version stored, I will update this. (Also why I am happy to add this early on)