matchms / ms2deepscore

Deep learning similarity measure for comparing MS/MS spectra with respect to their chemical similarity
Apache License 2.0
48 stars 22 forks source link

Type check settings #210

Closed niekdejonge closed 3 months ago

niekdejonge commented 4 months ago

Added a quick check to check that the settings are of the correct type (the same as the default).

I did accidentally switch two settings and it only breaks after calculating all tanimoto scores, which is a bit annoying.

There were two issues I had to fix:

Both are fixed now. But the list requirement for additional metadata is now fixed. Do you think that is okay? Or shall we remove the type check?

Alternatively I could write a quick function that does checks for iterables instead of just checking the type.