Update SiameseModel to tensorflow 2.6

matchms / ms2deepscore

Deep learning similarity measure for comparing MS/MS spectra with respect to their chemical similarity

Apache License 2.0

53 stars 24 forks source link

Closed florian-huber closed 3 years ago

florian-huber commented 3 years ago

Some of our code breaks with the most recent version of Tensorflow (see issue #91).

I had to change the assertion that looks for a valid keras model. (we could maybe add another assert such as assert model.layers, "Expected valid keras model as input" ?)
To be sure it doesn't now break for former tensorflow version I added CI tests for Tensorflow >=2.4,<2.5 and >=2.5, <2.6.
Tensorflow recommends to not use tensorflow.python.keras imports anymore, so I replaced that as well.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

florian-huber commented 3 years ago

Thanks a lot for reviewing, Sven!