search

matchu / Strict-Workflow

A Chrome extension that helps you stay focused by blocking sites during work timers and letting you browse during break timers
https://chrome.google.com/webstore/detail/cgmnfnmlficgeijcalkgnnkigkefkbhd
Other
193 stars 97 forks source link

Add separate whitelist and blocklist #14

Open blickly opened 12 years ago

blickly commented 12 years ago

Currently, there is only one "site list" that is used for both the blacklist and whitelist. This means that users who want to switch between these two types of blocking must clobber one list every time.

This patch fixes this problem by adding two separate lists for the whitelist and blacklist.

matchu commented 12 years ago

Interesting idea! Good call for usability :)

I feel like, before deploying, we'd need to think a bit more about a default whitelist that would work for many users — clearly it's harder than a default blacklist, and a truly perfect solution is impossible, but we can definitely arrive at a good starting point. The default blacklist was based on a list of the 50 (I think) most popular sites on the web and deciding which are almost never work-related. The default whitelist oughta be based on that same pattern rather than what we as developers just so happen to consider our work-related sites.

Also, I'd like to keep the new naming convention of "site" instead of "domain" for pref keys, since we now support path-based entries like "google.com/calendar", which is a site but isn't a domain.

After those changes, I'll give the merge a final look for style consistency and run a bunch of paranoid checks on the new prefs-update function (unless maybe you've already done 'em?), and we'll move from there :) Thanks!

blickly commented 12 years ago

I agree that we should change the default whitelist, as currently it's just my whitelist unchanged. It seems like its harder to say for certain that a site is universally work-related than that it universally isn't, so I would err on the side of having too few sites in the whitelist over too many. Also, since the default is to blacklist sites, anyone who is using the whitelist mode must have at least looked at the options page.

I changed the names according to your convention, as well as the name of "whitelistEl" to "whitelistSelectEl", since I think that's clearer.

I haven't tested the prefs-update, so I'd be glad if you did that. Thanks!

blickly commented 11 years ago

On more thought, I think it probably makes most sense for the default whitelist to be empty. Since users must go into the options to switch away from the blacklist, I think it's reasonable to expect that they have some idea of which sites to whitelist. Users who don't change the default options will never interact with the default whitelist anyway.

matchu commented 11 years ago

That makes good sense.

Sorry this pull request has been so thoroughly back-burnered. I'm hoping to be able to get a new release out this month once exams are done, so we'll see how that goes :) Thanks for your patience, bro.