search

matco / badminton

Badminton application for Garmin watches
https://apps.garmin.com/en-US/apps/51606451-57e2-4f99-9420-2ba5a80b5df6
The Unlicense
30 stars 10 forks source link

Add setting to display current time instead of match duration #12

Closed bennygui closed 7 years ago

bennygui commented 7 years ago

Fixes issue #11

matco commented 7 years ago

Thanks a lot for your contribution!

I don't have the time right now to do a full review. I will have some time in one week.

However, don't you think that it shouldn't be the time -or- the timer. Maybe the option should just be "Display the time". I think we can find some room on the top of the match screen to display the time.

Also, there is no API in the Garmin SDK to display a well-formatted time?!

bennygui commented 7 years ago

I will have to check if there is space at the top of the screen... although it doesn't seems like there is much space.

For the formatted time API, there doesn't seem to be anything but using System::ClockTime would probably be simpler.

matco commented 7 years ago

The layout of the match screen is dynamic and it should be easy to increase the top margin if the time is displayed.

bennygui commented 7 years ago

Added a new commit, the time can be displayed at the top now.

matco commented 7 years ago

Again, thanks a lot! With any luck I will release a new version this week.