matcornic / hugo-theme-learn

Porting Grav Learn theme to Hugo
https://learn.netlify.com/en/
MIT License
1.61k stars 1.28k forks source link

Q: Plans for a new release? #502

Open b-abel opened 3 years ago

b-abel commented 3 years ago

Hi there! Are there any plans for when a new version will be released? The issue #378 is very striking and we would love to use the already existing fix. But for this, we would need a released version.

muffmolch commented 3 years ago

project seems to be dead ... more or less .. :-(

mirisbowring commented 3 years ago

@McShelby is interested in bringing new features for more than a year now.

@McShelby, probably now is the time to do a fork? I know the open maintenance issue but since the maintainers are not active nor responsive, there are not many ways left if this project should not die.

muffmolch commented 3 years ago

@McShelby is interested in bringing new features for more than a year now.

@McShelby, probably now is the time to do a fork? I know the open maintenance issue but since the maintainers are not active nor responsive, there are not many ways left if this project should not die.

Yes, it seems to be the best. I don't know what's the problem in background, but he asked many times and nothing happens. Looking at his patches, I don't think it's because of bad coding ....

lkppo commented 3 years ago

A year off does not mean that the project is abandoned but rather that it is not a priority or that the project has exceeded the commitment that the maintainer wants to give.

Did someone offered to help him maintaining the project or become the new maintainer, if he no longer has interest?

It's much better than a fork.

muffmolch commented 3 years ago

A year off does not mean that the project is abandoned but rather that it is not a priority or that the project has exceeded the commitment that the maintainer wants to give.

Did someone offered to help him maintaining the project or become the new maintainer, if he no longer has interest?

It's much better than a fork.

As @mirisbowring said: @McShelby did! Quite often, bt nothin happens. There are also a lot of valid PRs open ...

muffmolch commented 3 years ago

@lkppo And a year in software development is an immense amount of time. hugo was at v0.72 a year ago and is now at v0.84. moreover, hugo is already reporting this theme depreacted messages ... so it's only a matter of time before it drops out of the list of officially available hugo themes.

But that's the known risk you take with one man libs. There is also nothing reprehensible about it. As you say, everyone has their own priorities. And if it just does not go further, then you just have to tackle it yourself ;-)

lkppo commented 3 years ago

I've seen this happen several times and the maintainer has come back or passed the torch. Before forking, ask the maintainer what their position is and make an offer if there are one or two people really willing to maintain. Opening multiple PRs / Issues and waiting is not the same as politely asking the question and showing that you are ready to help. The maintainer needs to think about it in general and maybe formulate things that he can't seem to say.

If you really do not receive an answer to this kind of question then fork after a reasonable delay (1 month?).

mirisbowring commented 3 years ago

@McShelby offered a video conference more then a month ago to talk to the maintainers: https://github.com/matcornic/hugo-theme-learn/issues/442

muffmolch commented 3 years ago

And that time, in my opinion, has simply passed. There are several threads here with offers to help support. Many small things, but also elementary things. From the creator's point of view, of course, it's not always easy. It's not a paid project and mostly just a byproduct that fell off somewhere else. From that point of view, I am also very grateful that this theme exists at all. But it must remain compatible to the current Hugo releases in the long run. I also use several third-party packages, some of which are out of date. There was a lot of promise here too, but in the end forking was the only viable solution, which is a shame because if it was my product I would love it to be used for a long time and would take other supporters on board. at least I would make some kind of statement. However, you have to remember that last year was an absolute exception and we don't know if that has anything to do with the discontinued fort development.

And as said now fpr many time: @McShelby would throw himself into the fire for us. Thus... let it happen :-)

McShelby commented 3 years ago

So at first: No offense here. No maintainer is forced to support his projects. If he has stepped away from it, so be it. The reasons for this are not mine to judge.

Nevertheless, the situation currently is still unsatisfiying for users of this theme. A lot of PRs are lingering in the queue. Some with (in my eyes) obvious bug fixes, some with more elaborate and very dedicated work. For supporters it is really discouraging if there isn't at least any feedback of a maintainer.

That's were I currently am. I already offered help in a few ways but besides from general doubt by the maintainers (which I can perfectly understand) there wasn't much of a feedback. Especially not for PRs, reviews or some perspective on how to proceed to gain more trust.

I know from personal experience, it is sometimes hard to admit a project once beloved, is now obsolete and outdated. As said above, a maintainer can decide whatever he wants to do with his projects, but in a public environment like Github it is at least fair (and in my eyes his responsiblity) to inform the community about the current state of project.

As often, communication is the key here. From that standpoint this is Schroedingers project. Not alive, not dead yet either.

jehoshua7 commented 3 years ago

Just adding a note here so I get notifications of any activity. I see there is a huge list of forks at https://github.com/matcornic/hugo-theme-learn/network/members . I'm assuming by the posts in this issue, the fork at https://github.com/McShelby/hugo-theme-relearn may seem to be the most current, and active, is that correct please ?

McShelby commented 3 years ago

I can only speak for myself: Yes, I started a fork last week at https://github.com/McShelby/hugo-theme-relearn.

I aim to work on open issues of this repo in the 1.x.x releases and stay as compatible to this theme as possible.

The 2.x.x version may see some more significant changes, but at this moment that's more fiction than a plan.

jehoshua7 commented 3 years ago

@McShelby Okay thanks for your reply. I uploaded your theme to a website today, and although it worked locally, it wouldn't work properly on a test website. After a few hours it suddenyl dawned on me to check the web server logs. All pages returned a 410 beccause I had Apache mods in .htaccess to look for a "?". Removed that and it worked fine. The moral of the story may be "check the web server logs first" ..lol

McShelby commented 3 years ago

I've forked this project to McShelby/hugo-theme-relearn. The fork is meant to be a drop-in replacement of this theme.

See further statement in #442.

DanielRuf commented 3 years ago

I've forked this project to McShelby/hugo-theme-relearn. The fork is meant to be a drop-in replacement of this theme.

See further statement in #442.

Sounds good. Which of the open issues and PRs are covered by the current changes in the fork?

McShelby commented 3 years ago

I'ld say around 60% and still counting. On all issues in this project you'll find references to corresponding issues in the fork if they are fixed

DanielRuf commented 3 years ago

I'ld say around 60% and still counting. On all issues in this project you'll find references to corresponding issues in the fork if they are fixed

Great. Can you need some help? I have still some issues and PRs open and maybe I could help there.

McShelby commented 3 years ago

Sure, you're welcome! Sadly, I've moved a lot of code, so existing PRs from this project most likely will not apply without conflicts and justification.