matcornic / hugo-theme-learn

Porting Grav Learn theme to Hugo
https://learn.netlify.com/en/
MIT License
1.6k stars 1.28k forks source link

Attachments URL wrong if site is deployed under subpath #550

Open Nightshadelink opened 1 year ago

Nightshadelink commented 1 year ago

Problem:

Whenever the web pages are not deployed in the root but under a subpath it shows that in the attachement.html a leading slash is used too much in the URL. So the full BasePath is not used relatively, but absolute "$fileDir", "$filesName" and ".Name".

Example:

Presumed cause:

In .../layouts/shortcodes/attachments.html

<a href="{{ (printf "%s%s/%s" $fileDir $filesName .Name) | relLangURL }}">{{.Name}}</a>

$fileDir probably (didn't test) carries a leading slash hence relLangURL does not utilize the BasePath fully.

Proposed modification:

Remove leading slash. This works for now, but presumably you have a better solution for fixing.

<a href="{{ slicestr (printf "%s%s/%s" $fileDir $filesName .Name) 1 | relLangURL }}">{{.Name}}</a>

System-Info:

vanilla deployed on github-pages