matcornic / hugo-theme-learn

Porting Grav Learn theme to Hugo
https://learn.netlify.com/en/
MIT License
1.6k stars 1.28k forks source link

link of logo not pointing to basepath #551

Open Nightshadelink opened 1 year ago

Nightshadelink commented 1 year ago

Problem:

Whenever the web pages are not deployed in the root but under a subpath you cannot use the click on the logo as the link points to the urls root and not the basepath of your website.

Presumed cause:

In .../layouts/partials/logo.html

<a id="logo" href='{{ (cond (and (ne .Site.Params.landingPageURL nil) (.Site.IsMultiLingual)) .Site.Params.landingPageURL "/") }}'>

no relLangURL so href does not carry the BasePath.

Proposed modification:

add relLangURL

<a id="logo" href='{{ (cond (and (ne .Site.Params.landingPageURL nil) (.Site.IsMultiLingual)) .Site.Params.landingPageURL "/") | relLangURL }}'>

System-Info:

vanilla deployed on github-pages

McShelby commented 1 year ago

This theme currently isn't really actively maintained. Meanwhile you could use my fork where this and a lot of other bugs are fixed.