search

matcornic / hugo-theme-learn

Porting Grav Learn theme to Hugo
https://learn.netlify.com/en/
MIT License
1.6k stars 1.28k forks source link

Language selector does not work with sub-folders in baseURL #65

Open bep opened 6 years ago

bep commented 6 years ago

See https://themes.gohugo.io/theme/hugo-theme-learn/en

matcornic commented 6 years ago

@bep thanks for the feedback !

matcornic commented 6 years ago

Hey @bep, is there a special configuration in the themes website that this theme does not handle well ?

I tried locally by setting baseURL = "http://localhost:1313/some/sub/folders" and it works pretty well : http://recordit.co/2zpgJSpP5w

bep commented 6 years ago

I have fixed the deploy previews on the theme repo, so I suggest you do the debugging with creating a PR and mark it as a "work in progress" or something. I don't have time to spend more time on this.

bep commented 6 years ago

A quick glance at your code I notice you do manual URL building with baseURL.

I recommend you use: