search

matdave / modx-monaco

Monaco integration for MODX
5 stars 0 forks source link

Modx and fenom syntax support #1

Open alexsoin opened 5 months ago

alexsoin commented 5 months ago

Thank you so much for implementing this add-on!

The only thing missing is the support for modx and fenom syntax))

Gulomov has already implemented syntax support for viscode:

https://github.com/GulomovCreative/modx-tmlanguage

https://github.com/GulomovCreative/fenom-tmlanguage

Perhaps this will help to implement this feature faster, without writing your own implementation from scratch.

GulomovCreative commented 5 months ago

MODX completions has also implemented to vscode

matdave commented 5 months ago

This only helps somewhat. Monaco doesn't support TextMate markup files, and uses Monarch as its text engine. They have a write-up about their experiments with TextMate in the browser and said the compilation time was abysmal. It's a helpful reference but doesn't make it "faster"

matdave commented 5 months ago

I've added basic modx syntax support here: https://github.com/matdave/modx-monaco/blob/1.0.1-pl/assets/components/monaco/modx-lang.js

I do not use fenom, so I'm not overly comfortable claiming I can create a language file for it. I am definitely open to a PR for it though.