search

mate-desktop-legacy-archive / mate-netspeed

Applet that shows traffic on a network device for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
4 stars 5 forks source link

[RPMLint] wrong-icon-size #8

Closed posophe closed 11 years ago

posophe commented 11 years ago

mate-netspeed.i586: W: wrong-icon-size /usr/share/icons/hicolor/24x24/status/mate-netspeed-wireless-50.png expected: 24x24 actual: 8x16 mate-netspeed.i586: W: wrong-icon-size /usr/share/icons/hicolor/24x24/status/mate-netspeed-wireless-100.png expected: 24x24 actual: 8x16 mate-netspeed.i586: W: wrong-icon-size /usr/share/icons/hicolor/24x24/status/mate-netspeed-wireless-75.png expected: 24x24 actual: 8x16 mate-netspeed.i586: W: wrong-icon-size /usr/share/icons/hicolor/24x24/status/mate-netspeed-wireless-25.png expected: 24x24 actual: 8x16 Your icon file is installed in a fixed-size directory, but has a largely incorrect size. Some desktop environments (e.g. GNOME) display them incorrectly.

raveit65 commented 11 years ago

I fixed this here. https://github.com/NiceandGently/mate-netspeed/commit/3449eddabc80d6645d033685b6dabd723f49057e But i have no wifi at home, can you test the change with a local test build?

posophe commented 11 years ago

Ok I make a try

posophe commented 11 years ago

@NiceandGently thanks ! It fix this issue. Please merge it

raveit65 commented 11 years ago

Last question. Does the wifi images displayed correct in the netspeed applet?

posophe commented 11 years ago

Ok, well displayed