search

mate-desktop / atril

A document viewer for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
203 stars 62 forks source link

check return value of xmlDocGetRootElement call if is NULL #486

Closed Yuuoniy closed 4 years ago

Yuuoniy commented 4 years ago

Fix for missing xmlDocGetRootElement() check problem in #485

raveit65 commented 4 years ago

Can you please squash all commits in one when all is done? No need of 2 new commits for fixing the main commit. Is it also possible to edit a commit with git instead of pushing new ones.

Yuuoniy commented 4 years ago

I‘ve made changes according to comments, and squashed all commits in one, but the build failed. Could you please take a little time to check for this? thanks.

raveit65 commented 4 years ago

It' a bit weird, because the build fails only for ubuntu:devel branch at travis. https://travis-ci.org/github/mate-desktop/atril/builds/720982908 So, i am thinking it's not related to PR. https://travis-ci.org/github/mate-desktop/atril/jobs/720982912#L4963

ERROR: files left in build directory after distclean:

./help/reference/shell/atril.actions

./help/reference/libview/libatrilview.actions

./help/reference/libdocument/libatrildocument.actions

make[1]: *** [Makefile:951: distcleancheck] Error 1

make[1]: Leaving directory '/rootdir/atril-1.25.0/_build/sub'

make: *** [Makefile:880: distcheck] Error 1

It fails during the make distcheck command. I guess that ubuntu-20-10 was branched the last days and something is wrong with ubuntu:devel docker image.

raveit65 commented 4 years ago

@Yuuoniy Building with ubuntu at travis is fixed in master. Can you please rebase? https://github.com/mate-desktop/atril/commit/03693b12f9d76bc16c02d5ac6ff42ad51c7316fa

Yuuoniy commented 4 years ago

@raveit65 I've done, would you please have a check?