mate-desktop / atril

A document viewer for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
203 stars 62 forks source link

Fix implicit conversion changes signedness: 'gboolean' to 'guint' #554

Closed rbuj closed 2 years ago

rbuj commented 2 years ago
CFLAGS="-g -O0 -Wconversion -Wunused-macros -Wunused-parameter" CC=clang ./autogen.sh --prefix=/usr --enable-debug --enable-compile-warnings=maximum && make &> make.log
ev-transition-effect.c:84:23: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                priv->rectangular = g_value_get_boolean (value);
                                  ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~
--
ev-document-model.c:503:21: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        model->dual_page = dual_page;
                         ~ ^~~~~~~~~
ev-document-model.c:569:27: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        model->inverted_colors = inverted_colors;
                               ~ ^~~~~~~~~~~~~~~
ev-document-model.c:593:22: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        model->continuous = continuous;
                          ~ ^~~~~~~~~~
ev-document-model.c:637:30: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        model->dual_page_odd_left = odd_left;
                                  ~ ^~~~~~~~
ev-document-model.c:661:22: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        model->fullscreen = fullscreen;
                          ~ ^~~~~~~~~~
--
ev-print-operation.c:1260:20: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        export->collate = gtk_print_settings_get_collate (print_settings);
                        ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ev-print-operation.c:1261:20: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        export->reverse = gtk_print_settings_get_reverse (print_settings);
                        ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
ev-timeline.c:390:15: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        priv->loop = loop;
                   ~ ^~~~
--
eggfindbar.c:620:30: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
      priv->case_sensitive = case_sensitive;
                           ~ ^~~~~~~~~~~~~~
raveit65 commented 2 years ago

@rbuj Can you please push PR to get a deployment?

rbuj commented 2 years ago

done

raveit65 commented 2 years ago

It seems that we have a new warning.

ev-timeline.c:390:21: warning: comparison between pointer and integer ('gboolean' (aka 'int') and 'void *') [-Wpointer-integer-compare]
        priv->loop = (loop != NULL);
                      ~~~~ ^  ~~~~
1 warning generated.
rbuj commented 2 years ago

@raveit65 done

raveit65 commented 2 years ago

Ok, all mentioned warnings are gone, now i start testing.

raveit65 commented 2 years ago

@mate-desktop/core-team Anyone else like to review this ticket?